Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support failure encoding in proxy gRPC interceptor #930

Closed
cretz opened this issue Oct 11, 2022 · 1 comment
Closed

Support failure encoding in proxy gRPC interceptor #930

cretz opened this issue Oct 11, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Oct 11, 2022

Is your feature request related to a problem? Please describe.

In #924 we added support to optionally move message and stack trace into encoded attributes. We need to support this for proxies too.

Describe the solution you'd like

Probably best to alter https://github.com/temporalio/sdk-go/blob/master/internal/cmd/generateinterceptor/main.go to add EncodeCommonAttributes bool to PayloadCodecGRPCClientInterceptorOptions and, if true, move the message and stack trace to the encoded attributes pre-encode (and back out post-decode). This will allow proxies using this interceptor to support encoded failure attributes transparently via the interceptor in the way that's understandable in the UI.
@cretz cretz added the enhancement New feature or request label Oct 11, 2022
@cretz cretz mentioned this issue Dec 6, 2022
Merged
@cretz
Copy link
Member Author

cretz commented Jan 11, 2023

This was done as converter.NewFailureGRPCClientInterceptor in #974

@cretz cretz closed this as completed Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cretz @Quinn-With-Two-Ns