Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lookahead to infer messages on all replay paths #1055

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Lookahead to infer messages on all replay paths #1055

merged 1 commit into from
Mar 7, 2023

Conversation

mmcshane
Copy link
Contributor

@mmcshane mmcshane commented Mar 6, 2023

What was changed

Include lookahead message inference on this path to workflow state rebuilding

Why?

Without inference, updates are not replayed

Checklist

  1. Closes

#1044

  1. How was this tested:

New unit test here.

  1. Any docs updates needed?

No

Lookahead to infer messages on all replay paths
ca9132f 
The replayer is not used in rebuilding workflow state if the context had
previously been destroyed (e.g. via a restart of the worker process) so
we include here the same message inference call that is used in the
replayer.
@mmcshane mmcshane requested a review from a team as a code owner March 6, 2023 21:59
bergundy
bergundy approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@bergundy bergundy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some regression test we can add that tests this E2E?

@mmcshane
Copy link
Contributor Author

mmcshane commented Mar 7, 2023

Is there some regression test we can that tests this E2E?

Working on adding it to features but that work has to include

  • dynamic skipping of tests based on sniffing namespace capabilities
  • stop/start of worker

So it has been slower going.

@mmcshane mmcshane merged commit 3ce152b into temporalio:master Mar 7, 2023
@mmcshane mmcshane deleted the mpm/infer-messages-during-catchup branch March 7, 2023 15:47
@mmcshane mmcshane mentioned this pull request Mar 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergundy bergundy bergundy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmcshane @bergundy