Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add message IDs to update messages #1079

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Add message IDs to update messages #1079

merged 1 commit into from
Apr 11, 2023

Conversation

mmcshane
Copy link
Contributor

What was changed

Adds message IDs to update messages

Why?

This was just missed earlier. The IDs will be necessary to refer to messages by ID in the future.

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

Add message IDs to update messages
2f8fae5 
This was just missed earlier.
@mmcshane mmcshane requested a review from a team as a code owner April 11, 2023 03:52
Quinn-With-Two-Ns
Quinn-With-Two-Ns approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@Quinn-With-Two-Ns Quinn-With-Two-Ns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll use the same convention in Java as well

@mmcshane mmcshane merged commit 0005c07 into temporalio:master Apr 11, 2023
@mmcshane mmcshane deleted the mpm/update-message-ids branch April 11, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmcshane @cretz @Quinn-With-Two-Ns