Update panic handling #1119
Merged
Update panic handling #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recover panics from validation by converting to PanicError - this will fail the update but not the WFT and will not trigger the WorkflowPanicPolicy. Panics from update execution still propagate out and will be handled by the task processing loop in accordance with the WorkflowPanicPolicy.
cretz
approved these changes
May 25, 2023
Quinn-With-Two-Ns
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Recover panics from update validation by converting to PanicError - this will fail the update but not the WFT and will not trigger the WorkflowPanicPolicy. Panics from update execution still propagate out and will be handled by the task processing loop in accordance with the WorkflowPanicPolicy.
Why?
Consistent with query error behavior. Doesn't run afoul of pending updates when PanicPolicy is FailWorkflow. Consistent with java sdk
Checklist
Closes
How was this tested:
unit test here & pending changes to task_failure features tests