Do not send original request msg back to server #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leave the AcceptedRequest and RejectedRequest fields nil on the Acceptance and Rejection messages respectively. Server has been updated to not look at these fields.
Quinn-With-Two-Ns
approved these changes
Jun 14, 2023
cretz
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Leave the AcceptedRequest and RejectedRequest fields nil on the Acceptance and Rejection messages respectively. Server has been updated to not look at these fields.
Why?
Giving up on reconstituting lost ephemeral update state from this information and thus the server does not look at these fields. Save the bytes for now and add back if we resurrect the server behavior.
Checklist
Closes
How was this tested:
Unit tests here and features tests