Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more mocks #1152

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Add more mocks #1152

merged 2 commits into from
Jun 30, 2023

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Add more client mocks for consistency

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner June 29, 2023 20:51
cretz
cretz reviewed Jun 29, 2023
View reviewed changes
mocks/ScheduleClient.go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want some test showing that this works

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 524b4d1 into temporalio:master Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Quinn-With-Two-Ns @cretz