Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make QueryWorkflowWithOptions go through interceptor #1171

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Make QueryWorkflowWithOptions go through the interceptor. Originally QueryWorkflowWithOptions was called by the interceptor which is wrong.

closes #991

@Quinn-With-Two-Ns Quinn-With-Two-Ns marked this pull request as ready for review July 23, 2023 20:55
@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner July 23, 2023 20:55
@@ -194,6 +194,11 @@ type (
// func which use a next token to get next page of history events
paginate func(nexttoken []byte) (*workflowservice.GetWorkflowExecutionHistoryResponse, error)
}

// queryRejectedError is a wrapper for QueryRejected
queryRejectedError struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was considering suggesting making this public, but since it's only for sending this across interceptor-to-client boundary because we can't change the interceptor signature nor the client signature, I'm ok w/ it being hidden. If a user ever wants to intercept query rejection, we can discuss making this available.

@Quinn-With-Two-Ns Quinn-With-Two-Ns force-pushed the query-with-options-interceptor branch from 5d0b8c5 to e51e8a2 Compare July 24, 2023 14:24
@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit a649812 into temporalio:master Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QueryWorkflowWithOptions not going through interceptor
2 participants