Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support for typed search attributes in child workflow options #1434

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Fix support for typed search attributes in child workflow options #1434

merged 1 commit into from
Apr 8, 2024

Conversation

cludden
Copy link
Member

@cludden cludden commented Apr 5, 2024

What was changed

Fix support for typed search attributes in child workflow options

Why?

Specifying TypedSearchAttributes on ChildWorkflowOptions does not propagate search attributes to the child workflow.

Checklist

  1. Closes
    n/a

  2. How was this tested:

  • Added unit test
  • Tested against local temporal server
  1. Any docs updates needed?
    n/a

@cludden cludden requested a review from a team as a code owner April 5, 2024 22:45
@Quinn-With-Two-Ns
Copy link
Contributor

Hey Chris, thanks this does look like a bug. Can we also add an integration test since the test environment is not the exact same code paths as a real server. Something like this test https://github.com/temporalio/sdk-go/blob/master/test/integration_test.go#L1318, but uses child workflows?

@cludden cludden force-pushed the cludden/child-workflow-typed-search-attributes branch from 0e829d6 to 241d648 Compare April 6, 2024 01:46
Quinn-With-Two-Ns
Quinn-With-Two-Ns approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@Quinn-With-Two-Ns Quinn-With-Two-Ns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will give some time before merging for @cretz to review if they want.

cretz
cretz approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 108aac8 into temporalio:master Apr 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cludden @Quinn-With-Two-Ns @cretz