Add SetFailureConverter to the activity and workflow test environments
#1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quinn-With-Two-Ns
approved these changes
May 21, 2024
cretz
approved these changes
May 21, 2024
|
Thanks for the review @Quinn-With-Two-Ns and @cretz 🙌 I've merged the base branch, so it looks like CI might need another approval. |
boxofrad
added a commit
to boxofrad/sdk-go
that referenced
this pull request
May 24, 2024
Follow up to temporalio#1484. 1. We weren't correctly threading the failure converter down to activities and child workflows, so they were still using the default converter. 2. The `NonRetryable` flag on the protobuf failure type wasn't being honored for custom errors.
Quinn-With-Two-Ns
pushed a commit
to boxofrad/sdk-go
that referenced
this pull request
May 29, 2024
Follow up to temporalio#1484. 1. We weren't correctly threading the failure converter down to activities and child workflows, so they were still using the default converter. 2. The `NonRetryable` flag on the protobuf failure type wasn't being honored for custom errors.
Quinn-With-Two-Ns
pushed a commit
that referenced
this pull request
May 31, 2024
Fix bugs when using a custom `FailureConverter` in tests Follow up to #1484. 1. We weren't correctly threading the failure converter down to activities and child workflows, so they were still using the default converter. 2. The `NonRetryable` flag on the protobuf failure type wasn't being honored for custom errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Adds a
SetFailureConvertermethod toTestWorkflowEnvironmentandTestActivityEnvironment.Supersedes #1433.
Why?
We use a custom failure converter to marshal/unmarshal structured errors in our application. These errors contain a "code" (similar to a gRPC status) which gets lost without the failure converter, so there are currently certain branches of our code that we're unable to test.