Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test duplicate rejected updates #1569

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Test duplicate rejected updates #1569

merged 1 commit into from
Jul 29, 2024

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Test duplicate rejected updates. Test that an update ID can be reused if it was rejected. I noticed this was broken in the Java SDK so adding a test here as well.

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner July 29, 2024 01:06
cretz
cretz approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's confusing from a user POV that update IDs can be reused, but understandable from a technical POV

@Quinn-With-Two-Ns Quinn-With-Two-Ns force-pushed the test-duplicate-rejected-updates branch from e10873b to 63c8fe3 Compare July 29, 2024 17:42
@Quinn-With-Two-Ns Quinn-With-Two-Ns force-pushed the test-duplicate-rejected-updates branch from 63c8fe3 to d4f950d Compare July 29, 2024 19:26
@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 2baa60e into temporalio:master Jul 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Quinn-With-Two-Ns @cretz