Handle Nexus links

[rodrigozhou]

What was changed

Handle Nexus links

Why?

Support Nexus bi-directional links.

Checklist

1. Closes

2. How was this tested:

3. Any docs updates needed?

[bergundy]

We shouldn't be defining these regexps here, you should be able to split the paths and let the server do the validation.
If this made it into the server codebase, you should change there too, I may have missed it Friday.

[bergundy]

For example, on the server, namespace doesn't have this character limitation:

func (wh *WorkflowHandler) validateNamespace(
	namespace string,
) error {
	if err := common.ValidateUTF8String("Namespace", namespace); err != nil {
		return err
	}
	if len(namespace) > wh.config.MaxIDLengthLimit() {
		return errNamespaceTooLong
	}
	return nil
}

If we changed the validation logic, we wouldn't want the SDK and server to go out of sync.

[rodrigozhou]

I didn't add anything on the server side. I did here in SDK only.

[bergundy]

I would just use splits by / here but this is fine if the regexp doesn't limit characters.

[rodrigozhou]

I just thought that validating the individual parts of the split a bit ugly. Regex looks cleaner.

[cretz]

Is all of this intended to be public user-facing API?

[rodrigozhou]

Yes, we need these functions in the server.

[cretz]

I think this converter package is for data/failure conversion, not for any thing that might need to be converted. I think this Nexus-specific stuff should go in the temporalnexus package. And I am not sure we should expose these utilities to users.

[bergundy]

Ah good point. There's a want to reuse this code in the server codebase to avoid duplicating this logic.

[cretz]

👍 Can move it and leave it public and document it as user facing since it will be

[bergundy]

We should expose the links in the workflow API on the NexusOperationExecution https://pkg.go.dev/go.temporal.io/sdk@v1.28.1/workflow#NexusOperationExecution and in workflow info when a workflow is started with a link.

We can do that in a follow up PR AFAIC.

[cretz]

I like the idea of the run ID being a query param too, but meh not important

[bergundy]

In the UI it's in the path.

[cretz]

How much of this is meant to match UI path vs HTTP API paths?

[bergundy]

In the UI it's in the path.