Fix Version test failure due to 1.25.0 server release #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuandrew
commented
Sep 10, 2024
cretz
approved these changes
Sep 10, 2024
Quinn-With-Two-Ns
approved these changes
Sep 10, 2024
ReyOrtiz
pushed a commit
to ReyOrtiz/temporal-sdk-go
that referenced
this pull request
Dec 5, 2024
* temporary test fix * change assert to match server behavior change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Changing a test assert based off of changed behavior from 1.25.0 server release. Test now checks for either no ramp or percentage is 100%
Why?
1.25.0 server release caused this test to start failing. Server was changed so we can specify a 100% ramp as equivalent to no ramp.
Checklist
Closes
How was this tested:
Test passes locally