Enforce nexus request timeout in workflow test suite #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigozhou
reviewed
Oct 1, 2024
Comment on lines
+2357
to
+2366
| // Use lower case header values to simulate how the Nexus SDK (used internally by the "real" server) would transmit | ||
| // these headers over the wire. | ||
| nexusHeader := make(map[string]string, len(params.nexusHeader)) | ||
| for k, v := range params.nexusHeader { | ||
| nexusHeader[strings.ToLower(k)] = v | ||
| } | ||
| params.nexusHeader = nexusHeader | ||
| // The real server allows requests to take up to 10 seconds, mimic that behavior here. | ||
| // Note that if a user sets the Request-Timeout header, it gets overridden. | ||
| params.nexusHeader[strings.ToLower(nexus.HeaderRequestTimeout)] = "10s" |
There was a problem hiding this comment.
We also set the request timeout for the cancel operation.
There was a problem hiding this comment.
Yes, this will set that timeout for all "requests".
|
Seems like there is an issue with this PR only on Windows |
Changed the test slightly, CI should pass now AFAICT. |
|
Looks like this is good to go @Quinn-With-Two-Ns. |
| params.nexusHeader = nexusHeader | ||
| // The real server allows requests to take up to 10 seconds, mimic that behavior here. | ||
| // Note that if a user sets the Request-Timeout header, it gets overridden. | ||
| params.nexusHeader[strings.ToLower(nexus.HeaderRequestTimeout)] = "10s" |
There was a problem hiding this comment.
Isn't the real server behaviour the minimum of 10s or the remaining schedule to close?
There was a problem hiding this comment.
Good point. Not at the moment, but we should enforce that eventually.
Quinn-With-Two-Ns
approved these changes
Oct 3, 2024
ReyOrtiz
pushed a commit
to ReyOrtiz/temporal-sdk-go
that referenced
this pull request
Dec 5, 2024
* Enforce nexus request timeout in workflow test suite * Use GreaterOrEqual to compare timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes issue where headers injected by workflow outbound interceptors in the test env were not normalized to lower case as done by the real server.