Fixed ActivityOptions.RetryPolicy documentation #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flossypurse
reviewed
Sep 23, 2020
internal/activity.go
Outdated
| // See more details about RetryPolicy on the doc for RetryPolicy. | ||
| // Optional: default is a server side provided retry policy. The default server side policy | ||
| // (which can be overridden by the dynamic config) is InitialInterval of 1 second, BackoffCoefficient of 2.0 | ||
| // and MaximumInterval of 100 times InitialInterval. To disable retries set MaximumAttempts to 1. |
There was a problem hiding this comment.
Consider:
// RetryPolicy specifies how to retry an Activity if an error occurs.
// More details are available at docs.temporal.io.
// RetryPolicy is optional. If one is not specified a default RetryPolicy is provided by the server.
// The default RetryPolicy provided by the server specifies:
// - InitialInterval of 1 second
// - BackoffCoefficient of 2.0
// - MaximumInterval of 100 x InitialInterval
// - MaximumAttempts of 0
// To disable retries set MaximumAttempts to 1.
// The default RetryPolicy provided by the server can be overridden by the dynamic config.
alexshtin
changed the title
flossypurse
approved these changes
Oct 26, 2020
muralisrini
pushed a commit
to muralisrini/sdk-go
that referenced
this pull request
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflect that Temporal provides a default retry policy for activities.