Fix spurious nil derefs on retrying local activities #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
force-pushed
the
fix-la-retry-nil-panic
branch
from
931eb98 to
bfb5695
Compare
wxing1292
reviewed
Dec 11, 2020
Comment on lines
-497
to
+499
| eventHandler := w.eventHandler.Load() | ||
| if eventHandler == nil { | ||
| if w.eventHandler == nil { | ||
| return nil | ||
| } | ||
| eventHandlerImpl, ok := eventHandler.(*workflowExecutionEventHandlerImpl) | ||
| if !ok { | ||
| panic("unknown type for workflow execution event handler") | ||
| } | ||
| return eventHandlerImpl | ||
| return (*w.eventHandler).(*workflowExecutionEventHandlerImpl) |
There was a problem hiding this comment.
do we need to grab a lock for this?
There was a problem hiding this comment.
since previously this is stored in atomic.Value
There was a problem hiding this comment.
Putting it here can cause deadlocks - generally functions calling into this one are doing the locking. Overall there's not much consistency around when the lock is taken. I'd be worth cleaning this up as part of the bigger refactorings I'll take on soon.
vitarb
reviewed
Dec 15, 2020
vitarb
approved these changes
Dec 16, 2020
muralisrini
pushed a commit
to muralisrini/sdk-go
that referenced
this pull request
Feb 4, 2024
Add session failure sample
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #302 being merged first
Relates to https://www.notion.so/Go-SDK-Nil-Reference-Panic-in-Bench-Test-b240b5f0db3b4d8088e3486939a53e78
It appears my fix in the MR this one depends on also fixes this item. I wasn't able to repro the issue after a variety of bench runs.Not quite. Will require a bit of extra fix.