Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of ContinueAsNewError #326

Merged
merged 2 commits into from
Jan 4, 2021
Merged

Conversation

mfateev
Copy link
Member

@mfateev mfateev commented Dec 31, 2020

Removed unnecessary fields from ContineAsNewError and exposed it through internalbidings package.

This was requested by SDK-PHP project.

@mfateev mfateev requested a review from vitarb December 31, 2020 05:08
wfn interface{}
args []interface{}
params *ExecuteWorkflowParams
//params *ExecuteWorkflowParams
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover comment line?

@mfateev mfateev merged commit 0811d35 into temporalio:master Jan 4, 2021
@mfateev mfateev deleted the continue-as-new branch January 4, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants