Add ParentClosePolicy to unit test #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
force-pushed
the
test_parent_policy
branch
from
f1addaa to
d3818de
Compare
vitarb
approved these changes
Jun 18, 2021
mfateev
reviewed
Jun 18, 2021
| if handle.env.parentEnv != nil && | ||
| env.workflowInfo.WorkflowExecution.ID == handle.env.parentEnv.workflowInfo.WorkflowExecution.ID { | ||
| // current env is parent workflow of handle's workflow | ||
| if handle.params.ParentClosePolicy == enumspb.PARENT_CLOSE_POLICY_REQUEST_CANCEL { |
There was a problem hiding this comment.
What about TERMINATE? I know it doesn't make sense for the root parent workflow, but what about the child of the child of the root?
There was a problem hiding this comment.
Good point. We need to handle that as well. Will do in a follow up PR.
Merged
yiminc
added a commit
that referenced
this pull request
Jun 21, 2021
Unit test to properly handle parent close policy of terminate. This is a follow up of #471
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add ParentClosePolicy to unit test
Why?
Properly support ParentClosePolicy in unit test.
Checklist
Closes Test to support ParentClosePolicy #470
How was this tested:
New unit tests
Any docs updates needed?
No.