Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop logging poller errors after stop #894

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Stop logging poller errors after stop #894

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60e4e24
Stop logging poller errors after stop
cretz Aug 29, 2022
776aadb
Merge branch 'master' into worker-fail-log
cretz Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions internal/internal_worker_base.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,13 @@ func (bw *baseWorker) pollTask() {
}

func (bw *baseWorker) logPollTaskError(err error) {
// We do not want to log any errors after we were explicitly stopped
select {
case <-bw.stopCh:
return
default:
}

bw.lastPollTaskErrLock.Lock()
defer bw.lastPollTaskErrLock.Unlock()
// No error means reset the message and time
Expand Down