bugfix: consistently plumb failureConverter #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Literal definitions of workflowRunImpl now consistently plumb the failureConverter through, fixing a panic we've been observing since the implementation of failureConverter.
|
|
bergundy
approved these changes
Nov 15, 2022
cretz
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
Not sure why the comments were reformatted but the fix LGTM.
https://golang.org/doc/comment was updated significantly in Go 1.19 and go fmt reflects it. Expect to see these more and more when these older files are touched.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Literal definitions of
workflowRunImplnow consistently plumb thefailureConverterthrough, fixing a panic we've been observing since the implementation of failureConverter.NOTE: some formatting nits included courtesy of
gofmtWhy?
The recent addition of a
failureConverteradded implicit not-nil assumption here, where we've been observing a nil-pointer panic. Even though the temporal client itself initializes a default failure converter, before this change it was not passed to workflowRunImpl.Checklist
N/A
By querying a failed workflow's status using the patched code. The unpatched code would panic, the patched code behaves as expected.
N/A