Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to override replayer execution info #998

Merged

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Add an option to the replayer to set workflow ID and run ID

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner January 5, 2023 17:26
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1465,6 +1483,54 @@ func (s *internalWorkerTestSuite) TestReplayWorkflowHistory_SideEffect() {
require.NoError(s.T(), err)
}

func (s *internalWorkerTestSuite) TestReplayWorkflowHistory_Bleh() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bleh? :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming hard

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 0d7304b into temporalio:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot set workflow ID for replayer Replayer uses different run ID than runtime after reset
2 participants