Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit continue-as-new that doesn't carry over some attributes of parent run if not set explicitly #1201

Open
1 of 2 tasks
Spikhalskiy opened this issue May 11, 2022 · 1 comment
Open
1 of 2 tasks

Revisit continue-as-new that doesn't carry over some attributes of parent run if not set explicitly #1201

Spikhalskiy opened this issue May 11, 2022 · 1 comment
Labels
enhancement User experience

Comments

@Spikhalskiy
Copy link
Contributor

Spikhalskiy commented May 11, 2022 •
edited
Loading

Expected Behavior

Users calling Workflow.continueAsNew without an explicit ContinueAsNewOptions expect most workflow properties to carry over to the new run.

Actual Behavior

Right now continueAsNew is implemented in a way that assumes that most parameters are carried over by the server if not specified on the continueAsNew request. While in fact, it's the opposite. Server doesn't carry over most parameters are not carried over by the server.

Additional context

This task requires also

  • a careful alignment with GoSDK
  • documenting in Temporal API repo which parameters are carried over by the Server from the previous run.
  • Test server should be updated to be aligned in its behavior with the real Temporal Server.

Related:
@Spikhalskiy Spikhalskiy added the enhancement User experience label May 11, 2022
@Spikhalskiy Spikhalskiy changed the title Revisit continue-as-new Revisit continue-as-new that doesn't carry over some attributes if not set explicitly Jul 28, 2022
@Spikhalskiy Spikhalskiy changed the title Revisit continue-as-new that doesn't carry over some attributes if not set explicitly Revisit continue-as-new that doesn't carry over some attributes of parent run if not set explicitly Jul 28, 2022
@patte patte mentioned this issue Aug 9, 2022
Closed
@Spikhalskiy Spikhalskiy self-assigned this Aug 11, 2022
@Quinn-With-Two-Ns Quinn-With-Two-Ns mentioned this issue May 23, 2023
Closed
@Quinn-With-Two-Ns
Copy link
Contributor

related: #1424

@Quinn-With-Two-Ns Quinn-With-Two-Ns mentioned this issue Dec 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement User experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Spikhalskiy @Quinn-With-Two-Ns