-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Package Version Information in manifest #2177
Comments
The Java SDK does contain a manifest, however the manifest may not contain package version information. There is no strong reason we cannot add that though. |
Yes I apologize I meant your Manifest is empty.
|
thanks in advance @Quinn-With-Two-Ns we are trying to create a Quarkus Extension for Temporal: https://github.com/quarkiverse/quarkus-temporal |
this can be done with some pseudo code below but I have no idea where to plug this into your Gradle build ecosystem. plugins {
id 'java'
}
jar {
manifest {
attributes(
'Implementation-Title': 'My Application',
'Implementation-Version': version,
)
}
} |
Your Manifest is how JARS are identified.
For example:
WorkflowClient.class.getPackage().getImplementationVersion()
returnsNULL
because your manifest is empty.A proper manifest you can genereate with GRadle easily to look something like this... from Caffeine.
The text was updated successfully, but these errors were encountered: