Fix test server publishing the Completion of child workflows before the Start sometimes #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spikhalskiy
requested review from
mfateev,
Sushisource,
cretz,
bergundy and
mmcshane
as code owners
Spikhalskiy
force-pushed
the
issue-1288
branch
2 times, most recently
from
21cc5bf to
67012d7
Compare
…he Start sometimes Issue temporalio#1288
Sushisource
approved these changes
Jun 27, 2022
This was referenced Jul 6, 2022
Open
natemort
added a commit
to natemort/cadence-java-client
that referenced
this pull request
Oct 25, 2024
By reporting child workflow started asynchronously we can observe a child workflow attempting to complete prior to its state machine registering that it started. This is an invalid state transition and causes test failures. See temporalio/sdk-java#1289 , we have the same test case still and it has similarly been flakey.
natemort
added a commit
to natemort/cadence-java-client
that referenced
this pull request
Oct 28, 2024
By reporting child workflow started asynchronously we can observe a child workflow attempting to complete prior to its state machine registering that it started. This is an invalid state transition and causes test failures. See temporalio/sdk-java#1289 , we have the same test case still and it has similarly been flakey.
natemort
added a commit
to natemort/cadence-java-client
that referenced
this pull request
Oct 29, 2024
By reporting child workflow started asynchronously we can observe a child workflow attempting to complete prior to its state machine registering that it started. This is an invalid state transition and causes test failures. See temporalio/sdk-java#1289 , we have the same test case still and it has similarly been flakey.
natemort
added a commit
to cadence-workflow/cadence-java-client
that referenced
this pull request
Oct 29, 2024
By reporting child workflow started asynchronously we can observe a child workflow attempting to complete prior to its state machine registering that it started. This is an invalid state transition and causes test failures. See temporalio/sdk-java#1289 , we have the same test case still and it has similarly been flakey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix use of thread in test server leading to parent workflow observing the completion of child workflows before the start in some cases.
Closes #1288
Closes #814