Support terminate-if-running workflow ID reuse policy in test server #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffschoner-stripe
force-pushed
the
test-service-terminate-if-running
branch
from
e1aa098 to
632f37b
Compare
Spikhalskiy
approved these changes
Mar 1, 2023
| try { | ||
| workflowStub.execute(); | ||
| } catch (WorkflowFailedException e) { | ||
| // Expected |
There was a problem hiding this comment.
If it's expected, you may consider asserting it with assertThrows.
Spikhalskiy
reviewed
Mar 1, 2023
| import org.junit.Test; | ||
|
|
||
| /** | ||
| * Server should discard repeated workflow task failures and let the workflow task to time out |
There was a problem hiding this comment.
Is this a relevant comment?
There was a problem hiding this comment.
Oops, copy/paste leftovers. I'll remove it.
jeffschoner-stripe
force-pushed
the
test-service-terminate-if-running
branch
from
632f37b to
76aa3cd
Compare
|
@Spikhalskiy Removed that comment, and asserted the expected exception. |
Spikhalskiy
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Terminates any existing execution in the test service when the terminate-if-running workflow ID reuse policy is specified. A new test has been added for this case, but also some basic workflow ID reuse policy test cases.
Why?
Starting a workflow with this policy when another is already running throws
WorkflowExecutionAlreadyStartedrather than the existing execution being terminated and a new run being started.Checklist
Closes Add support for TerminateIfRunning WorkflowIdReusePolicy in Test Server #1682
How was this tested:
New unit tests in
temporal-test-server/src/test/java/io/temporal/testserver/functional/WorkflowIdReusePolicyTest.java