Drop Python 3.8, confirm 3.13

temporalio · Dec 11, 2024 · a200bb5 · a200bb5
1 parent 853889c
commit a200bb5
Show file tree

Hide file tree

Showing 14 changed files with 395 additions and 443 deletions.
diff --git a/.github/workflows/build-binaries.yml b/.github/workflows/build-binaries.yml
@@ -32,7 +32,7 @@ jobs:
           submodules: recursive
       - uses: actions/setup-python@v5
         with:
-          python-version: "3.12"
+          python-version: "3.13"
 
       # Install Rust locally for non-Linux (Linux uses an internal docker
       # command to build with cibuildwheel which uses rustup install defined

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -12,30 +12,23 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python: ["3.8", "3.12"]
+        python: ["3.9", "3.13"]
         os: [ubuntu-latest, ubuntu-arm, macos-intel, macos-arm, windows-latest]
         include:
           - os: ubuntu-latest
-            python: "3.12"
+            python: "3.13"
             docsTarget: true
             cloudTestTarget: true
             clippyLinter: true
           - os: ubuntu-latest
-            python: "3.8"
+            python: "3.9"
             protoCheckTarget: true
           - os: ubuntu-arm
             runsOn: ubuntu-24.04-arm64-2-core
           - os: macos-intel
-            runsOn: macos-12
+            runsOn: macos-13
           - os: macos-arm
-            runsOn: macos-14
-        # macOS ARM 3.8 does not have an available Python build at
-        # https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json.
-        # See https://github.com/actions/setup-python/issues/808 and
-        # https://github.com/actions/python-versions/pull/259.
-        exclude:
-          - os: macos-arm
-            python: "3.8"
+            runsOn: macos-latest
     runs-on: ${{ matrix.runsOn || matrix.os }}
     steps:
       - uses: actions/checkout@v4
@@ -45,19 +38,23 @@ jobs:
       - uses: Swatinem/rust-cache@v2
         with:
           workspaces: temporalio/bridge -> target
+      # - uses: actions/setup-python@v5
+      #   with:
+      #     # Pinning due to failed Windows builds on 3.12.5 https://github.com/temporalio/sdk-python/issues/637
+      #     python-version: ${{ matrix.python == '3.12' && '3.12.4' || matrix.python }}
       - uses: actions/setup-python@v5
         with:
-          # Pinning due to failed Windows builds on 3.12.5 https://github.com/temporalio/sdk-python/issues/637
-          python-version: ${{ matrix.python == '3.12' && '3.12.4' || matrix.python }}
+          python-version: ${{ matrix.python }}
       - uses: arduino/setup-protoc@v3
         with:
           # TODO(cretz): Can upgrade proto when https://github.com/arduino/setup-protoc/issues/99 fixed
           version: "23.x"
           repo-token: ${{ secrets.GITHUB_TOKEN }}
-      # Using fixed Poetry version until
-      # https://github.com/python-poetry/poetry/issues/7611 and
-      # https://github.com/python-poetry/poetry/pull/7694 are fixed
-      - run: python -m pip install --upgrade wheel "poetry==1.3.2" poethepoet
+      # # Using fixed Poetry version until
+      # # https://github.com/python-poetry/poetry/issues/7611 and
+      # # https://github.com/python-poetry/poetry/pull/7694 are fixed
+      # - run: python -m pip install --upgrade wheel "poetry==1.3.2" poethepoet
+      - run: python -m pip install --upgrade wheel poetry poethepoet
       - run: poetry install --no-root --all-extras
       - run: poe bridge-lint
         if: ${{ matrix.clippyLinter }}
@@ -93,7 +90,7 @@ jobs:
         env:
           TEMPORAL_TEST_PROTO3: 1
         run: |
-          poetry add "protobuf<4"
+          poetry add --python 3.9 "protobuf<4"
           poe gen-protos
           poe format
           [[ -z $(git status --porcelain temporalio) ]] || (git diff temporalio; echo "Protos changed"; exit 1)
@@ -122,3 +119,4 @@ jobs:
       python-repo-path: ${{github.event.pull_request.head.repo.full_name}}
       version: ${{github.event.pull_request.head.ref}}
       version-is-repo-ref: true
+      features-repo-ref: python-version-upgrade
diff --git a/.github/workflows/run-bench.yml b/.github/workflows/run-bench.yml
@@ -37,7 +37,7 @@ jobs:
           workspaces: temporalio/bridge -> target
       - uses: actions/setup-python@v5
         with:
-          python-version: "3.12"
+          python-version: "3.13"
       - uses: arduino/setup-protoc@v3
         with:
           # TODO(cretz): Can upgrade proto when https://github.com/arduino/setup-protoc/issues/99 fixed

diff --git a/README.md b/README.md
@@ -1,6 +1,6 @@
 ![Temporal Python SDK](https://assets.temporal.io/w/py-banner.svg)
 
-[![Python 3.8+](https://img.shields.io/pypi/pyversions/temporalio.svg?style=for-the-badge)](https://pypi.org/project/temporalio)
+[![Python 3.9+](https://img.shields.io/pypi/pyversions/temporalio.svg?style=for-the-badge)](https://pypi.org/project/temporalio)
 [![PyPI](https://img.shields.io/pypi/v/temporalio.svg?style=for-the-badge)](https://pypi.org/project/temporalio)
 [![MIT](https://img.shields.io/pypi/l/temporalio.svg?style=for-the-badge)](LICENSE)
 
@@ -1367,7 +1367,7 @@ The Python SDK is built to work with Python 3.8 and newer. It is built using
 
 To build the SDK from source for use as a dependency, the following prerequisites are required:
 
-* [Python](https://www.python.org/) >= 3.8
+* [Python](https://www.python.org/) >= 3.9
   * Make sure the latest version of `pip` is in use
 * [Rust](https://www.rust-lang.org/)
 * [Protobuf Compiler](https://protobuf.dev/)