Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Failure.encoded_attributes not being subjected to codec #247

Closed
cretz opened this issue Jan 10, 2023 · 0 comments · Fixed by #251
Closed

[Bug] Failure.encoded_attributes not being subjected to codec #247

cretz opened this issue Jan 10, 2023 · 0 comments · Fixed by #251
Labels
bug Something isn't working

Comments

@cretz
Copy link
Member

cretz commented Jan 10, 2023 •
edited
Loading

Describe the bug

Seems PayloadCodec.encode_failure and PayloadCodec.decode_failure missed this field as part of #185
@cretz cretz added the bug Something isn't working label Jan 10, 2023
cretz added a commit to cretz/temporal-sdk-python that referenced this issue Jan 13, 2023
@cretz
Properly encode failure encoded attributes
2588687 
Fixes temporalio#247
@cretz cretz mentioned this issue Jan 13, 2023
Merged
cretz added a commit that referenced this issue Jan 23, 2023
@cretz
Properly encode failure encoded attributes (#251)
82f723b 
Fixes #247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Properly encode failure encoded attributes cretz/temporal-sdk-python
1 participant
@cretz