Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types-protobuf dependency is still on 3.x, while package supports protobuf 4.x #277

Closed
schibrikov opened this issue Feb 15, 2023 · 2 comments · Fixed by #278
Closed

types-protobuf dependency is still on 3.x, while package supports protobuf 4.x #277

schibrikov opened this issue Feb 15, 2023 · 2 comments · Fixed by #278

Comments

@schibrikov
Copy link
Contributor

schibrikov commented Feb 15, 2023 •
edited
Loading

Hi, the title says it all.
The problem with types-protobuf 3.x for me is this issue python/typeshed#5800.
In short: using types-protobuf 3.x overrides google cloud SDK typings, so I want to upgrade.

Can we change

protobuf = ">=3.20"
types-protobuf = "~3.20"

to

protobuf = ">=3.20"
types-protobuf = ">=3.20"

?
@cretz
Copy link
Member

cretz commented Feb 15, 2023

Definitely can change that. I should have done so when backporting this library to work with proto 3.x library. Feel free to PR or wait a bit and I'll get to it. Thanks for the report!

@schibrikov
Copy link
Contributor Author

Good, I guess I'll try to make a PR

@schibrikov schibrikov mentioned this issue Feb 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change types-protobuf dependency spec to match protobuf schibrikov/sdk-python
2 participants
@cretz @schibrikov