Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document workflow-friendly concurrency control #554

Closed
drewhoskins-temporal opened this issue Jun 18, 2024 · 3 comments · May be fixed by #567
Closed

Document workflow-friendly concurrency control #554

drewhoskins-temporal opened this issue Jun 18, 2024 · 3 comments · May be fixed by #567

Comments

@drewhoskins-temporal
Copy link

drewhoskins-temporal commented Jun 18, 2024 •
edited by dandavison
Loading

Document and add tests confirming that asyncio.Lock and asyncio.Semaphore can be used to control interleaving of signal and update handlers and the main workflow coroutine.
Closed
6 tasks
@dandavison dandavison mentioned this issue Jul 1, 2024
Open
@sreeprasannar
Copy link

does this mean currently using asyncio.Lock could lead to a deadlock?

@dandavison dandavison changed the title Workflow-friendly concurrency control Document workflow-friendly concurrency control Jul 29, 2024
@dandavison
Copy link
Contributor

Hi @sreeprasannar

does this mean currently using asyncio.Lock could lead to a deadlock?

No -- using asyncio.Lock in sdk-python workflow code is appropriate and recommended.

Thanks! I've changed the title & wording of this ticket.

@drewhoskins-temporal
Copy link
Author

temporalio/samples-python#123
temporalio/documentation#2959

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tests of asyncio.Lock and asyncio.Semaphore usage temporalio/sdk-python
3 participants
@dandavison @sreeprasannar @drewhoskins-temporal