Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure converter #185

Merged
merged 4 commits into from
Nov 7, 2022
Merged

Failure converter #185

merged 4 commits into from
Nov 7, 2022

Conversation

cretz
Copy link
Member

@cretz cretz commented Nov 3, 2022

What was changed

  • Added temporalio.converter.FailureConverter and supported it on the data converter
  • Added default failure converter and moved all conversion code and tests from temporalio.exceptions
  • Added support for encoded failure attributes
  • Added PayloadConverter.default, FailureConverter.default, and DataConverter.default singleton class variables
  • Deprecated temporalio.converter.default() in favor of temporalio.converter.DataConverter.default
  • Added DefaultPayloadConverter.default_encoding_payload_converters for others to reference when creating their own payload converters
  • Tests and docs

Checklist

  1. Closes [Feature Request] Support FailureConverter concept #142
  2. Closes Expose default sequence of payload converters for custom converter creators #139
  3. Closes [Feature Request] Apply codecs to Failure.encodedAttributes #131

@cretz cretz requested a review from a team November 3, 2022 13:58
Quinn-With-Two-Ns
Quinn-With-Two-Ns approved these changes Nov 4, 2022
View reviewed changes
Copy link

@Quinn-With-Two-Ns Quinn-With-Two-Ns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have we tried parsing a workflow history generated from Go or TS? just curious it should be compatible.

@cretz
Copy link
Member Author

cretz commented Nov 4, 2022

LGTM, have we tried parsing a workflow history generated from Go or TS? just curious it should be compatible.

Have not (for this or many cross-language things). Maybe an SDK features entry could do that.

@cretz cretz merged commit 929dc81 into temporalio:main Nov 7, 2022
@cretz cretz deleted the failure-convert branch November 7, 2022 14:17
@cretz cretz mentioned this pull request Jan 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cretz @Quinn-With-Two-Ns