Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Expose AbortController in Workflow sandbox #1564

Open
lukeramsden opened this issue Nov 15, 2024 · 0 comments · May be fixed by #1576
Open

[Feature Request] Expose AbortController in Workflow sandbox #1564

lukeramsden opened this issue Nov 15, 2024 · 0 comments · May be fixed by #1576
Labels
enhancement New feature or request

Comments

@lukeramsden
Copy link
Contributor

lukeramsden commented Nov 15, 2024

Is your feature request related to a problem? Please describe.

xstate is a very useful library for implementing state machines in TypeScript codebases. There is a specific feature that is particularly prudent to my usecase - fromPromise. Internally this uses an AbortController as part of it's implementation (see here). In the same vein as #1550, I have a patch locally that exposes AbortController to the vm sandbox, and everything seems to work fine (at least for my usage of xstate currently). From reading the docs this seems like a perfectly safe API to expose to the sandbox.

Describe the solution you'd like

Expose AbortController to the worker workflow sandbox.

Additional context

@lukeramsden lukeramsden added the enhancement New feature or request label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant