[Bug] replay workflow with log interceptor not showing logs

[Irvenae]

What are you really trying to do?

I am trying to get logs in my output when I am replaying a workflow. I am using my own logger, which is based on https://github.com/temporalio/samples-typescript/tree/main/instrumentation before it had the default helper functions.

Describe the bug

No log output when replaying a workflow that uses interceptors.

Screenshot when running the workflow (mind that in my example I changed the winston logger with a console logger, in my non-public code I am using a winston logger though):

Screenshot when replaying the workflow:

(Mind that the sink is known, otherwise you get Workflow referenced an unregistered external sink (which is not seen now))
I am running the test with Jest.

Minimal Reproduction

I think you can reproduce by running https://github.com/temporalio/samples-typescript/tree/main/instrumentation
combined with https://github.com/temporalio/samples-typescript/tree/main/replay-history.

I can make a branch if necessary, but this feels as quite basic functionality.

Environment/Versions

Mac M1
Temporal SDK 1.5.2
Temporal in docker.
Node version: v16.15.0

[bergundy]

Hey,
Thanks for reporting.
I agree that we should allow logs to be emitted during replays, we just got a contribution for Go SDK to make this configurable.

We should add the same in TS.

[Irvenae]

Seems like you can set it on a more general level:

sdk-typescript/packages/worker/src/sinks.ts

Line 26 in a661d16

* - `callDuringReplay` - whether or not `fn` will be called during Workflow

thanks @mjameswh for the suggestion.