You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we have eg. MarshalBinary and MarshalBinaryBare where the former includes a length prefix and the later does not. It seems more natural to switch the default behaviour to not be length prefixed (afaik proto3 does not auto-include a length prefix), and to have MarshalBinaryLengthPrefix instead of MarshalBinaryBare
The text was updated successfully, but these errors were encountered:
I agree, this should be the default behaviour. And you are right, that proto3 doesn't encode the length by default. Length delimiting is used for streaming AFAIK. I think some implementations do not even provide length delimited encoding / decoding. Most do though (java, prost/rust).
I think we should change this pre-launch as this would be breaking. Do you agree?
First step (rename MarshalBinary) was addressed in #222. Will update depending projects to use the new API. After that we could either rename MarshalBinaryBare to MarshalBinary, or, we could keep the Bare postfix.
Currently we have eg.
MarshalBinary
andMarshalBinaryBare
where the former includes a length prefix and the later does not. It seems more natural to switch the default behaviour to not be length prefixed (afaik proto3 does not auto-include a length prefix), and to have MarshalBinaryLengthPrefix instead of MarshalBinaryBareThe text was updated successfully, but these errors were encountered: