This repository has been archived by the owner on Jun 3, 2020. It is now read-only.
tendermint-rs: Add tests for /block_results RPC endpoint
#268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there was only a live integration test. This tests against a vendored RPC result for cosmoshub-1, and does a number of assertions on how the data is parsed. It also simplifies the API somewhat through the addition of some custom parsers that eliminate superfluous `Option` types (e.g. where an empty `Vec` would suffice).
tarcieri
force-pushed
the
tendermint-rs/block-results-test
branch
from
d9ed27c
to
3e1c142
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there was only a live integration test.
This tests against a vendored RPC result for cosmoshub-1, and does a number of assertions on how the data is parsed.
It also simplifies the API somewhat through the addition of some custom parsers that eliminate superfluous
Optiontypes (e.g. where an emptyVecwould suffice).