Upgrade signatory -> 0.15; yubihsm -> 0.28; use chacha20poly1305 crate #366
Conversation
This commit updates `signatory` and `yubihsm` to the latest versions. This requires either upgrading *ring* to 0.16, or replacing it: informalsystems/tendermint-rs#11 This commit has opted to replace it with the (i.e. my) `chacha20poly1305` crate: https://github.com/RustCrypto/AEADs/tree/master/chacha20poly1305 While *ring* is a great crate with excellent cryptographic implementations, the inability to link two versions of `ring-asm` is a major impediment to doing upgrades, as it requires updating all *ring*-dependent dependencies at once, or not at all, which so far has been a major blocker and has been stalling KMS development for awhile. As we're only using it for ChaCha20Poly1305, it seems like a rather heavyweight dependency just to serve that one purpose.
|
A quick note on performance: the That said, we're nowhere close to performance bound on symmetric encryption speed, so I don't think it really matters. |
| PrivateKey::Ed25519(pk) => pk.to_seed(), | ||
| PrivateKey::Ed25519(pk) => { | ||
| // TODO(tarcieri): upgrade Signatory version | ||
| ed25519::Seed::from_bytes(pk.to_seed().as_secret_slice()).unwrap() |
There was a problem hiding this comment.
Since tendermint-rs v0.10 is still linking signatory v0.12, it necessitates these gross thunks.
However, I think it should be pretty easy to update it and cut another release now that the ring and Secret Connection code will be out-of-the-way.
| .map_err(|_| ErrorKind::Crypto)? | ||
| .len() | ||
| } else { | ||
| let mut in_out = ciphertext.to_vec(); |
There was a problem hiding this comment.
@liamsi I was a bit curious what case you're trying to handle here. It seems like it only helps in the event that the out buffer is up to the tag length smaller than the input ciphertext, but any shorter than that and the code below will still panic when it slices out out-of-bounds
tarcieri
deleted the
signatory-0-15-yubihsm-0-28-chacha20poly1305-crate
branch
This commit updates
signatoryandyubihsmto the latest versions.This requires either upgrading ring to 0.16, or replacing it:
informalsystems/tendermint-rs#11
This commit has opted to replace it with the (i.e. my)
chacha20poly1305crate:https://github.com/RustCrypto/AEADs/tree/master/chacha20poly1305
While ring is a great crate with excellent cryptographic implementations, the inability to link two versions of
ring-asmis a major impediment to doing upgrades, as it requires updating all ring-dependent dependencies at once, or not at all, which so far has been a major blocker and has been stalling KMS development for awhile. As we're only using it for ChaCha20Poly1305, it seems like a rather heavyweight dependency just to serve that one purpose.