fix(codegen): protoc to keep snake_case for swagger and ts out #2149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clockworkgr
requested review from
fadeev,
ilgooz,
lumtis,
Pantani and
ivanovpetr
as code owners
|
Removed SpVuexError usage because |
marinhoarthur
previously approved these changes
Mar 15, 2022
ilgooz
added a commit
that referenced
this pull request
Mar 16, 2022
* fix: protoc to keep snake_case for swagger and ts out * refactor * removed SpVuexError Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com> Co-authored-by: marinhoarthur <arthurtutuca@gmail.com>
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
…e#2149) * fix: protoc to keep snake_case for swagger and ts out * refactor * removed SpVuexError Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com> Co-authored-by: marinhoarthur <arthurtutuca@gmail.com>
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
…e#2149) * fix: protoc to keep snake_case for swagger and ts out * refactor * removed SpVuexError Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com> Co-authored-by: marinhoarthur <arthurtutuca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generate_javascript and generate_openapi were generating types incompatible with the json models of the API
Added:
json_names_for_fields=falseoption to the openapi protoc plugin--ts_proto_opt=snakeToCamel=falseto the ts-proto protoc plugin