Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(buildkit): Support build-time HTTP_PROXY #193

Closed
gaocegege opened this issue May 24, 2022 · 3 comments · Fixed by #857
Closed

feat(buildkit): Support build-time HTTP_PROXY #193

gaocegege opened this issue May 24, 2022 · 3 comments · Fixed by #857
Assignees
@gaocegege
Labels
area/buildkit 🚢 area/docker 🐳 priority/3-low 💙 type/feature 💡

Comments

@gaocegege
Copy link
Member

Description

			FrontendAttrs: map[string]string{
				"build-arg:HTTPS_PROXY": os.Getenv("HTTPS_PROXY"),
			},

Buildkit supports some build time attrs in its dockerfile frontend. We need to support them in envd.
@gaocegege
Copy link
Member Author

Ref https://github.com/docker/buildx/issues/136#issuecomment-523575934https://github.com/docker/buildx/issues/136#issuecomment-523575934

@gaocegege gaocegege self-assigned this Sep 7, 2022
@gaocegege
Copy link
Member Author

I will work on this.

@gaocegege
Copy link
Member Author

Ref moby/buildkit#971

@gaocegege gaocegege mentioned this issue Sep 9, 2022
Merged
@gaocegege gaocegege moved this to Done in envd sprint board Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gaocegege gaocegege

Labels
area/buildkit 🚢 area/docker 🐳 priority/3-low 💙 type/feature 💡
Projects
No open projects
envd sprint board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Support HTTP PROXY gaocegege/envd
1 participant
@gaocegege