Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add envd as a new language extension in github linguist #339

Open
VoVAllen opened this issue Jun 14, 2022 · 5 comments
Open

feat: Add envd as a new language extension in github linguist #339

VoVAllen opened this issue Jun 14, 2022 · 5 comments
Assignees
@VoVAllen
Labels
priority/3-low 💙 type/feature 💡

Comments

@VoVAllen
Copy link
Member

Description

Example from tilt github-linguist/linguist#4831
@kemingy
Copy link
Member

kemingy commented Aug 19, 2022

This should be done by https://github.com/tensorchord/envd-lsp

@kemingy
Copy link
Member

kemingy commented Sep 2, 2022

It will be better if the vscode plugin can also modify the envd file icon.

@VoVAllen
Copy link
Member Author

Not viable now. Github requires language popularity (grammar used in hundreds of repos held by different people), that envd doesn't satisfy yet.

@VoVAllen VoVAllen self-assigned this Sep 13, 2022
@gaocegege
Copy link
Member

https://github.com/github/linguist/blob/master/CONTRIBUTING.md#adding-an-extension-to-a-language

We try only to add languages once they have some usage on GitHub. In most cases we prefer that each new file extension be in use in at least 200 unique :user/:repo repositories before supporting them in Linguist (but see #5756 for a temporary change in the criteria).

@gaocegege
Copy link
Member

Ref github-linguist/linguist#5756

@gaocegege gaocegege changed the title feat: Add envd as the suffix name for syntax highlight with starlark feat: Add envd as a new language extension in github linguist Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VoVAllen VoVAllen

Labels
priority/3-low 💙 type/feature 💡
Projects
No open projects
envd sprint board
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gaocegege @VoVAllen @kemingy