Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: envd bootstrap can't find buildkitd if it was stopped #397

Closed
Triple-Z opened this issue Jun 16, 2022 · 2 comments
Closed

bug: envd bootstrap can't find buildkitd if it was stopped #397

Triple-Z opened this issue Jun 16, 2022 · 2 comments

Comments

@Triple-Z
Copy link
Contributor

Description

envd bootstrap gets error if the envd_buildkitd was stopped before.

so9fpJJz0l

Reproduction

  1. Stop the envd_buildkitd container.
  2. Run the envd bootstrap.

Additional Info

None.

@gaocegege
Copy link
Member

gaocegege commented Jun 17, 2022

We just need to update code here

https://github.com/tensorchord/envd/blob/main/pkg/docker/docker.go#L273

+	// Add logic to check if the container is stopped.
	resp, err := g.ContainerCreate(ctx, config, hostConfig, nil, nil, name)
	if err != nil {
		return "", errors.Wrap(err, "failed to create container")
	}

	for _, w := range resp.Warnings {
		logger.Warnf("run with warnings: %s", w)
	}

	if err := g.ContainerStart(ctx, resp.ID, types.ContainerStartOptions{}); err != nil {
		return "", errors.Wrap(err, "failed to start container")
	}

@Triple-Z
Copy link
Contributor Author

close due to #417 has merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants