Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.

feat(docs): Document the image requirements #104

Open
gaocegege opened this issue Aug 3, 2023 · 4 comments
Open

feat(docs): Document the image requirements #104

gaocegege opened this issue Aug 3, 2023 · 4 comments

Comments

@gaocegege
Copy link
Member

gaocegege commented Aug 3, 2023

We need an http probe route in the container localhost:port/

Or the HTTP probe will fail.

@cybergeekgyan
Copy link

I would love to work on this issue, Can you assign it to me and also I would like to know how to proceed with this issue
@gaocegege

@gaocegege
Copy link
Member Author

We should add a section in https://docs.open.modelz.ai/deployment/deploy or somewhere, to tell users that the image should run a single-port http server, and provide a http healthz check endpoint. We will use "/" by default.

@kemingy
Copy link
Member

kemingy commented Aug 10, 2023

BTW, we already support mdz deploy --probe-path /healthz.

@kemingy
Copy link
Member

kemingy commented Aug 14, 2023

Hi @cybergeekgyan any progress for this issue? Feel free to ask here if you have any questions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants