Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fold rules_cuda into bazelbuild/rules_cuda #56

Open
dmadisetti opened this issue May 4, 2021 · 4 comments
Open

Fold rules_cuda into bazelbuild/rules_cuda #56

dmadisetti opened this issue May 4, 2021 · 4 comments

Comments

@dmadisetti
Copy link

Ideally rules_cuda should be split away from this project. Even the README of rules_cuda has the repo located at its own repository.

You probably have this tracked internally, but for the rest of us, I thought it would be a good idea to open this ticket as somewhere we can refer. I get that this is probably pretty low priority.

Thanks for your work chsigg and team

@chsigg
Copy link
Collaborator

chsigg commented Jun 22, 2021

Hi Dylan.

You are absolutely right. @rules_cuda needs a better home. I've talked to the bazel folks before and it sounded like adding it to bazelbuild would come with a relatively high maintenance commitment, so I was a little on the fence. Maybe http://github.com/tensorflow/toolchains would be the better home. Hopefully this will bubble up in our priority list with TF and TFRT slowly converging.

@jsharpe
Copy link

jsharpe commented Nov 19, 2021

@chsigg the newly formed SIG rules authors may be a better home for this now; see https://github.com/bazel-contrib/SIG-rules-authors.
The process to on-board rulesets hasn't been defined but feel free to start a discussion about this in the SIG-rules-authors repo if this is something you would like to do.

I certainly have an interest in the rules_cuda ruleset so would love to see it hosted outside the tensorflow/runtime repository; I would definitely support having it in bazel-contrib as a ruleset as I think having a canonical cuda ruleset available is a worthy aim.

@chsigg
Copy link
Collaborator

chsigg commented Nov 24, 2021

Hi James, thanks for letting me know. I would be happy to upstream this to bazel-contrib. I will get in contact with the SIG.

@ryanleary
Copy link

https://github.com/bazel-contrib/rules_cuda has been created. Would be great to identify any gaps preventing migration of TF to use these new rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants