From b25a3b4700c666240f2100df581067421b44d33d Mon Sep 17 00:00:00 2001 From: Qihang Chen Date: Thu, 25 Jul 2024 11:11:34 -0700 Subject: [PATCH] =?UTF-8?q?LSC=20=E2=80=94=20Explicitly=20mark=20AOT=20inc?= =?UTF-8?q?ompatible=20targets=20via=20'jit:true'?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../webapp/app_routing/effects/app_routing_effects_test.ts | 2 +- .../views/feature_flag_modal_trigger_container_test.ts | 1 + tensorboard/webapp/plugins/testing/index.ts | 1 + tensorboard/webapp/testing/integration_test_module.ts | 1 + .../webapp/webapp_data_source/tb_feature_flag_testing.ts | 1 + .../webapp/webapp_data_source/tb_http_client_testing.ts | 1 + .../intersection_observer_testing_module.ts | 3 ++- tensorboard/webapp/widgets/resize_detector_testing_module.ts | 1 + 8 files changed, 9 insertions(+), 2 deletions(-) diff --git a/tensorboard/webapp/app_routing/effects/app_routing_effects_test.ts b/tensorboard/webapp/app_routing/effects/app_routing_effects_test.ts index 2bc28b2fe5e..10543e6db20 100644 --- a/tensorboard/webapp/app_routing/effects/app_routing_effects_test.ts +++ b/tensorboard/webapp/app_routing/effects/app_routing_effects_test.ts @@ -48,7 +48,7 @@ import { } from '../types'; import {AppRoutingEffects, TEST_ONLY} from './app_routing_effects'; -@Component({selector: 'test', template: ''}) +@Component({selector: 'test', template: '', jit: true}) class TestableComponent {} const testAction = createAction('[TEST] test action'); diff --git a/tensorboard/webapp/feature_flag/views/feature_flag_modal_trigger_container_test.ts b/tensorboard/webapp/feature_flag/views/feature_flag_modal_trigger_container_test.ts index 5bb82fde767..232a223a0e0 100644 --- a/tensorboard/webapp/feature_flag/views/feature_flag_modal_trigger_container_test.ts +++ b/tensorboard/webapp/feature_flag/views/feature_flag_modal_trigger_container_test.ts @@ -37,6 +37,7 @@ import { @Component({ selector: 'testable-feature-flag-dialog-container', template: '
Test
', + jit: true, }) class TestableFeatureFlagDialogContainer {} diff --git a/tensorboard/webapp/plugins/testing/index.ts b/tensorboard/webapp/plugins/testing/index.ts index e33b7edd3dc..6dc92e29bb5 100644 --- a/tensorboard/webapp/plugins/testing/index.ts +++ b/tensorboard/webapp/plugins/testing/index.ts @@ -26,5 +26,6 @@ export class ExtraDashboardComponent {} imports: [ PluginRegistryModule.forPlugin('extra-plugin', ExtraDashboardComponent), ], + jit: true, }) export class ExtraDashboardModule {} diff --git a/tensorboard/webapp/testing/integration_test_module.ts b/tensorboard/webapp/testing/integration_test_module.ts index b60e0c5dcae..0cbae56e130 100644 --- a/tensorboard/webapp/testing/integration_test_module.ts +++ b/tensorboard/webapp/testing/integration_test_module.ts @@ -33,6 +33,7 @@ import {MatIconTestingModule} from './mat_icon_module'; @Component({ selector: 'test', template: 'hello', + jit: true, }) export class TestableComponent {} diff --git a/tensorboard/webapp/webapp_data_source/tb_feature_flag_testing.ts b/tensorboard/webapp/webapp_data_source/tb_feature_flag_testing.ts index f19879e7b1e..bb04dddc4f5 100644 --- a/tensorboard/webapp/webapp_data_source/tb_feature_flag_testing.ts +++ b/tensorboard/webapp/webapp_data_source/tb_feature_flag_testing.ts @@ -42,5 +42,6 @@ export class TestingTBFeatureFlagDataSource extends TBFeatureFlagDataSource { useExisting: TestingTBFeatureFlagDataSource, }, ], + jit: true, }) export class TBFeatureFlagTestingModule {} diff --git a/tensorboard/webapp/webapp_data_source/tb_http_client_testing.ts b/tensorboard/webapp/webapp_data_source/tb_http_client_testing.ts index 0a9aa4898fd..22c7ffcdb9c 100644 --- a/tensorboard/webapp/webapp_data_source/tb_http_client_testing.ts +++ b/tensorboard/webapp/webapp_data_source/tb_http_client_testing.ts @@ -34,5 +34,6 @@ import {TBHttpClientModule} from './tb_http_client_module'; ), }), ], + jit: true, }) export class TBHttpClientTestingModule {} diff --git a/tensorboard/webapp/widgets/intersection_observer/intersection_observer_testing_module.ts b/tensorboard/webapp/widgets/intersection_observer/intersection_observer_testing_module.ts index 2000366e223..6c48c4b48e1 100644 --- a/tensorboard/webapp/widgets/intersection_observer/intersection_observer_testing_module.ts +++ b/tensorboard/webapp/widgets/intersection_observer/intersection_observer_testing_module.ts @@ -16,7 +16,7 @@ import {Directive, EventEmitter, NgModule, Output} from '@angular/core'; import {ComponentFixture} from '@angular/core/testing'; import {By} from '@angular/platform-browser'; -@Directive({selector: '[observeIntersection]'}) +@Directive({selector: '[observeIntersection]', jit: true}) class IntersectionObserverTestingDirective { @Output() onVisibilityChange = new EventEmitter<{visible: boolean}>(); @@ -28,6 +28,7 @@ class IntersectionObserverTestingDirective { @NgModule({ exports: [IntersectionObserverTestingDirective], declarations: [IntersectionObserverTestingDirective], + jit: true, }) export class IntersectionObserverTestingModule { simulateVisibilityChange(fixture: ComponentFixture, visible: boolean) { diff --git a/tensorboard/webapp/widgets/resize_detector_testing_module.ts b/tensorboard/webapp/widgets/resize_detector_testing_module.ts index 7a81c7e9e9b..01c3f20d8c0 100644 --- a/tensorboard/webapp/widgets/resize_detector_testing_module.ts +++ b/tensorboard/webapp/widgets/resize_detector_testing_module.ts @@ -29,6 +29,7 @@ class ResizeDetectorTestingDirective { @NgModule({ exports: [ResizeDetectorTestingDirective], declarations: [ResizeDetectorTestingDirective], + jit: true, }) export class ResizeDetectorTestingModule { simulateResize(fixture: ComponentFixture) {