persistent settings: expose OSSSettingsConverter as DI-able #5387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, OSSSettingsCOnverter is only acquirable by injecting a symbol, SettingsConverter. If we want to compose the converter in a type safe manner, we have to convert the converter to be a generic or compose by injecting an instance of the converter. Here, we have decided to take the latter approach which tends to keep the base implementation simple to reason with without generics.
bmd3k
approved these changes
Oct 28, 2021
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
…ow#5387) Currently, OSSSettingsCOnverter is only acquirable by injecting a symbol, SettingsConverter. If we want to compose the converter in a type safe manner, we have to convert the converter to be a generic or compose by injecting an instance of the converter. Here, we have decided to take the latter approach which tends to keep the base implementation simple to reason with without generics.
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
…ow#5387) Currently, OSSSettingsCOnverter is only acquirable by injecting a symbol, SettingsConverter. If we want to compose the converter in a type safe manner, we have to convert the converter to be a generic or compose by injecting an instance of the converter. Here, we have decided to take the latter approach which tends to keep the base implementation simple to reason with without generics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, OSSSettingsCOnverter is only acquirable by injecting a
symbol, SettingsConverter. If we want to compose the converter in a type
safe manner, we have to convert the converter to be a generic or compose
by injecting an instance of the converter. Here, we have decided to take
the latter approach which tends to keep the base implementation simple
to reason with without generics.