Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout: make resizer smaller #5390

Merged
merged 2 commits into from
Oct 28, 2021
Merged

Conversation

stephanwlee
Copy link
Contributor

Previously, we used to have a little icon and thick vertical bar to make
resize affordance apparent on the left pane resizer. After surveying
modern apps, it looks like they are often done with pointer in
combination with thicker vertical bar on hover so we adopt those
designs.

In the end, with this change, we give users about 18 pixels back in the
horizontal space.

Before:
image

No hover:
image

Hover:
image

Previously, we used to have a little icon and thick vertical bar to make
resize affordance apparent on the left pane resizer. After surveying
modern apps, it looks like they are often done with pointer in
combination with thicker vertical bar on hover so we adopt those
designs.

In the end, with this change, we give users about 18 pixels back in the
horizontal space.
@@ -30,22 +30,32 @@ limitations under the License.
.expand {
@include tb-theme-foreground-prop(border-color, border);
box-sizing: border-box;
flex: 0 0 20px;
flex: 0 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this change anything?
the width of the expand is still depending on the width of the icon [>] (which is 19px and ~20px)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out. I forgot to add one file in my commit. I did remove the icon from the template.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked again. What I mean was expand_more_24px
It seems to me (mac, chrome) the expand element does not change with and without flex attribute;
Yet the icon seems bigger (24px) with setting width (line 35)

I want to make sure these are intended change (the expander getting wider).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean the icon is bigger (24px) without setting width of expand element (line 35)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, indeed you are correct. I have forgotten about the expander which is separate from the resize bar. Have put the width back on the expander.

Copy link
Contributor

@japie1235813 japie1235813 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@stephanwlee
Copy link
Contributor Author

Thank you for the thorough review and fast turn around!

@stephanwlee stephanwlee merged commit f3bf2be into tensorflow:master Oct 28, 2021
@stephanwlee stephanwlee deleted the slim branch October 28, 2021 23:24
yatbear pushed a commit to yatbear/tensorboard that referenced this pull request Mar 27, 2023
Previously, we used to have a little icon and thick vertical bar to make
resize affordance apparent on the left pane resizer. After surveying
modern apps, it looks like they are often done with pointer in
combination with thicker vertical bar on hover so we adopt those
designs.

In the end, with this change, we give users about 18 pixels back in the
horizontal space.
dna2github pushed a commit to dna2fork/tensorboard that referenced this pull request May 1, 2023
Previously, we used to have a little icon and thick vertical bar to make
resize affordance apparent on the left pane resizer. After surveying
modern apps, it looks like they are often done with pointer in
combination with thicker vertical bar on hover so we adopt those
designs.

In the end, with this change, we give users about 18 pixels back in the
horizontal space.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants