timeseries: fix button toggle state issue #5398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angular material components are not truly "controlled input" that even if the parent sets `checked` state to false, if user clicked on the button from false to true to cause a redux state change that makes parent put that state, it will have a value `checked`. This is directly observable by printing out value of `checked` vs. value set by parent. We work around this issue by simply using button that acts like a checkbox instead of using an Angular material component. Also, styled carefully to make it look about the same.
japie1235813
approved these changes
Nov 4, 2021
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
Angular material components are not truly "controlled input" that even if the parent sets `checked` state to false, if user clicked on the button from false to true to cause a redux state change that makes parent put that state, it will have a value `checked`. This is directly observable by printing out value of `checked` vs. value set by parent. We work around this issue by simply using button that acts like a checkbox instead of using an Angular material component. Also, styled carefully to make it look about the same.
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
Angular material components are not truly "controlled input" that even if the parent sets `checked` state to false, if user clicked on the button from false to true to cause a redux state change that makes parent put that state, it will have a value `checked`. This is directly observable by printing out value of `checked` vs. value set by parent. We work around this issue by simply using button that acts like a checkbox instead of using an Angular material component. Also, styled carefully to make it look about the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular material components are not truly "controlled input" that even
if the parent sets
checkedstate to false, if user clicked on thebutton from false to true to cause a redux state change that makes
parent put that state, it will have a value
checked. This is directlyobservable by printing out value of
checkedvs. value set by parent.We work around this issue by simply using button that acts like a
checkbox instead of using an Angular material component. Also, styled
carefully to make it look about the same.