Time Series: preserve run regex filter string in URL #5412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanwlee
approved these changes
Nov 10, 2021
| @@ -27,3 +27,5 @@ export const PINNED_CARDS_KEY = 'pinnedCards'; | |||
| export const RUN_COLOR_GROUP_KEY = 'runColorGroup'; | |||
|
|
|||
| export const TAG_FILTER_KEY = 'tagFilter'; | |||
|
|
|||
| export const RUN_REGEX_FILTER_KEY = 'runRegexFilter'; | |||
There was a problem hiding this comment.
Perhaps simpler, runFilter to match tagFilter? They are both regexes.
There was a problem hiding this comment.
Isn't tagFilter related to another filter? (where the arrow points at)
t)
There was a problem hiding this comment.
So, in L29, we have "tagFilter" instead of "tagRegexFilter" even though tag filter also let you specify a regex.
Likewise, I am asking if we can drop word" regex" from "runRegexFilter" like we did for tag one.
There was a problem hiding this comment.
ah I see. I thought you want to rename runRegexFilter to tag..
| }) | ||
| ); | ||
|
|
||
| expect(nextState.data.regexFilter).toEqual('hello'); |
There was a problem hiding this comment.
toEqual -> toBe. Here and below.
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time Series does not remember regex query put in the run filter. We remember this by adding it to the URL.