From f3886053bc108c63e0d7e41ff5ee7047eeb7748d Mon Sep 17 00:00:00 2001 From: Jie-Wei Wu Date: Tue, 16 Nov 2021 23:49:46 -0800 Subject: [PATCH 1/2] fix dark mode color --- .../views/main_view/card_group_toolbar_component.scss | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tensorboard/webapp/metrics/views/main_view/card_group_toolbar_component.scss b/tensorboard/webapp/metrics/views/main_view/card_group_toolbar_component.scss index 7595c9b2a99..fe26d7ab458 100644 --- a/tensorboard/webapp/metrics/views/main_view/card_group_toolbar_component.scss +++ b/tensorboard/webapp/metrics/views/main_view/card_group_toolbar_component.scss @@ -34,11 +34,16 @@ limitations under the License. cursor: pointer; } } + + @include tb-dark-theme { + .group-toolbar { + color: map-get($tb-dark-foreground, text); + } + } } .expand-group-icon { @include tb-theme-foreground-prop(color, secondary-text); - background-color: $metrics-button-background-color-on-gray; &:disabled { @include tb-theme-foreground-prop(color, disabled-text); From ef648a1ee65d1fd7a1f5254a482bd3cc92824fa3 Mon Sep 17 00:00:00 2001 From: Jie-Wei Wu Date: Wed, 17 Nov 2021 09:34:13 -0800 Subject: [PATCH 2/2] ac --- .../views/main_view/card_group_toolbar_component.scss | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/tensorboard/webapp/metrics/views/main_view/card_group_toolbar_component.scss b/tensorboard/webapp/metrics/views/main_view/card_group_toolbar_component.scss index fe26d7ab458..fc76271d40f 100644 --- a/tensorboard/webapp/metrics/views/main_view/card_group_toolbar_component.scss +++ b/tensorboard/webapp/metrics/views/main_view/card_group_toolbar_component.scss @@ -21,6 +21,7 @@ limitations under the License. .group-toolbar { border: 0; @include tb-theme-foreground-prop(border-top, border, 1px solid); + @include tb-theme-foreground-prop(color, text); // border-top on group-toolbar needs to be offset on sticky header for the // flawless UI. top: -1px; @@ -34,12 +35,6 @@ limitations under the License. cursor: pointer; } } - - @include tb-dark-theme { - .group-toolbar { - color: map-get($tb-dark-foreground, text); - } - } } .expand-group-icon {