From 4df7180bef7ace909a5d093a10b6c6dd79de3c2e Mon Sep 17 00:00:00 2001 From: Shivam Mishra Date: Mon, 10 Apr 2023 22:57:01 +0530 Subject: [PATCH 1/4] Migrate stale management probot to Github action --- .github/stale.yml | 39 --------------------- .github/workflows/stale.yaml | 66 ++++++++++++++++++++++++++++++++++++ 2 files changed, 66 insertions(+), 39 deletions(-) delete mode 100644 .github/stale.yml create mode 100644 .github/workflows/stale.yaml diff --git a/.github/stale.yml b/.github/stale.yml deleted file mode 100644 index b6a20870de9..00000000000 --- a/.github/stale.yml +++ /dev/null @@ -1,39 +0,0 @@ -# Copyright 2019 The TensorFlow Authors. All Rights Reserved. - # - # Licensed under the Apache License, Version 2.0 (the "License"); - # you may not use this file except in compliance with the License. - # You may obtain a copy of the License at - # - # http://www.apache.org/licenses/LICENSE-2.0 - # - # Unless required by applicable law or agreed to in writing, software - # distributed under the License is distributed on an "AS IS" BASIS, - # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - # See the License for the specific language governing permissions and - # limitations under the License. - # ============================================================================ - # - # THIS IS A GENERATED DOCKERFILE. - # - # This file was assembled from multiple pieces, whose use is documented - # throughout. Please refer to the TensorFlow dockerfiles documentation - # for more information. - -# Number of days of inactivity before an Issue or Pull Request becomes stale -daysUntilStale: 7 -# Number of days of inactivity before a stale Issue or Pull Request is closed -daysUntilClose: 7 -# Only issues or pull requests with all of these labels are checked if stale. Defaults to `[]` (disabled) -onlyLabels: - - stat:awaiting response -# Comment to post when marking as stale. Set to `false` to disable -markComment: > - This issue has been automatically marked as stale because it has not had - recent activity. It will be closed in 7 days if no further activity occurs. Thank you. -# Comment to post when removing the stale label. Set to `false` to disable -unmarkComment: false -closeComment: > - Closing as stale. Please @mention us if this needs more attention. -limitPerRun: 30 -# Limit to only `issues` or `pulls` -only: issues diff --git a/.github/workflows/stale.yaml b/.github/workflows/stale.yaml new file mode 100644 index 00000000000..254881bba6c --- /dev/null +++ b/.github/workflows/stale.yaml @@ -0,0 +1,66 @@ +# Copyright 2023 The TensorFlow Authors. All Rights Reserved. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# ============================================================================== + +# This workflow alerts and then closes the stale issues/PRs after specific time +# You can adjust the behavior by modifying this file. +# For more information, see: +# https://github.com/actions/stale + +name: 'Close stale issues and PRs' +"on": + schedule: + - cron: "30 1 * * *" +permissions: + contents: read + issues: write + pull-requests: write +jobs: + stale: + runs-on: ubuntu-latest + steps: + - uses: 'actions/stale@v7' + with: + # Comma separated list of labels that can be assigned to issues to exclude them from being marked as stale. + exempt-issue-labels: 'override-stale' + # Comma separated list of labels that can be assigned to PRs to exclude them from being marked as stale. + exempt-pr-labels: "override-stale" + # Limit the No. of API calls in one run default value is 30. + operations-per-run: 1000 + # Prevent to remove stale label when PRs or issues are updated. + remove-stale-when-updated: false + # comment on issue if not active for more then 7 days. + stale-issue-message: 'This issue has been marked stale because it has no recent activity since 7 days. It will be closed if no further activity occurs. Thank you.' + # comment on PR if not active for more then 14 days. + stale-pr-message: 'This PR has been marked stale because it has no recent activity since 14 days. It will be closed if no further activity occurs. Thank you.' + # comment on issue if stale for more then 7 days. + close-issue-message: This issue was closed due to lack of activity after being marked stale for past 7 days. + # comment on PR if stale for more then 14 days. + close-pr-message: This PR was closed due to lack of activity after being marked stale for past 14 days. + # Number of days of inactivity before an Issue Request becomes stale + days-before-issue-stale: 7 + # Number of days of inactivity before a stale Issue is closed + days-before-issue-close: 7 + # reason for closed the issue default value is not_planned + close-issue-reason: completed + # Number of days of inactivity before a stale PR is closed + days-before-pr-close: 14 + # Number of days of inactivity before an PR Request becomes stale + days-before-pr-stale: 14 + # Check for label to stale or close the issue/PR + any-of-labels: 'stat:awaiting response' + # override stale to stalled for PR + stale-pr-label: 'stale' + # override stale to stalled for Issue + stale-issue-label: "stale" \ No newline at end of file From ce0779a9671f1e18de8c8b9589fc851ea70a45ac Mon Sep 17 00:00:00 2001 From: Shivam Mishra Date: Mon, 10 Apr 2023 23:01:35 +0530 Subject: [PATCH 2/4] Migrate stale management probot to Github action --- .github/workflows/stale.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/stale.yaml b/.github/workflows/stale.yaml index 254881bba6c..c79824a4218 100644 --- a/.github/workflows/stale.yaml +++ b/.github/workflows/stale.yaml @@ -37,7 +37,7 @@ jobs: # Comma separated list of labels that can be assigned to PRs to exclude them from being marked as stale. exempt-pr-labels: "override-stale" # Limit the No. of API calls in one run default value is 30. - operations-per-run: 1000 + operations-per-run: 500 # Prevent to remove stale label when PRs or issues are updated. remove-stale-when-updated: false # comment on issue if not active for more then 7 days. From 793723cb7d1506aef5a94139bc42b9c15d0b6bae Mon Sep 17 00:00:00 2001 From: shmishra99 Date: Fri, 23 Jun 2023 17:08:07 +0530 Subject: [PATCH 3/4] Fixed typos in documentation string. --- tfjs-converter/src/executor/graph_executor.ts | 2 +- tfjs-converter/src/executor/graph_model.ts | 2 +- tfjs-converter/src/executor/tensor_array.ts | 2 +- tfjs-tfdf/BUILD.bazel | 2 +- tfjs-tfdf/README.md | 2 +- tfjs-vis/demos/mnist/index.html | 4 ++-- tfjs-vis/src/components/surface.tsx | 2 +- tfjs-vis/src/components/visor.tsx | 2 +- tfjs-vis/src/types.ts | 4 ++-- 9 files changed, 11 insertions(+), 11 deletions(-) diff --git a/tfjs-converter/src/executor/graph_executor.ts b/tfjs-converter/src/executor/graph_executor.ts index 52f7d481e8a..da34b1d692c 100644 --- a/tfjs-converter/src/executor/graph_executor.ts +++ b/tfjs-converter/src/executor/graph_executor.ts @@ -452,7 +452,7 @@ export class GraphExecutor implements FunctionExecutor { * @param isFunctionExecution Optional. Flag for executing a function. * @param tensorArrayMap Optional, global TensorArray map by id. Used for * function execution. - * @param tensorArrayMap Optinal global TensorList map by id. Used for + * @param tensorArrayMap Optional global TensorList map by id. Used for * function execution. */ private async _executeAsync( diff --git a/tfjs-converter/src/executor/graph_model.ts b/tfjs-converter/src/executor/graph_model.ts index ef9c8ad57a1..03802836084 100644 --- a/tfjs-converter/src/executor/graph_model.ts +++ b/tfjs-converter/src/executor/graph_model.ts @@ -295,7 +295,7 @@ export class GraphModel implements * Execute the inference for the input tensors. * * @param input The input tensors, when there is single input for the model, - * inputs param should be a `tf.Tensor`. For models with mutliple inputs, + * inputs param should be a `tf.Tensor`. For models with multiple inputs, * inputs params should be in either `tf.Tensor`[] if the input order is * fixed, or otherwise NamedTensorMap format. * diff --git a/tfjs-converter/src/executor/tensor_array.ts b/tfjs-converter/src/executor/tensor_array.ts index b69553ffb48..21344cbc7c3 100644 --- a/tfjs-converter/src/executor/tensor_array.ts +++ b/tfjs-converter/src/executor/tensor_array.ts @@ -240,7 +240,7 @@ export class TensorArray { /** * Scatter the values of a Tensor in specific indices of a TensorArray. - * @param indices nummber[] values in [0, max_value). If the + * @param indices number[] values in [0, max_value). If the * TensorArray is not dynamic, max_value=size(). * @param tensor Tensor input tensor. */ diff --git a/tfjs-tfdf/BUILD.bazel b/tfjs-tfdf/BUILD.bazel index b133797af4d..b9f65832065 100644 --- a/tfjs-tfdf/BUILD.bazel +++ b/tfjs-tfdf/BUILD.bazel @@ -48,7 +48,7 @@ tfjs_bundle( ], ) -# Copy ouput files to dist/. +# Copy output files to dist/. copy_ts_library_to_dist( name = "copy_src_to_dist", srcs = [ diff --git a/tfjs-tfdf/README.md b/tfjs-tfdf/README.md index 81d196f44d6..7096864fb29 100644 --- a/tfjs-tfdf/README.md +++ b/tfjs-tfdf/README.md @@ -1,6 +1,6 @@ # Tensorflow Decision Forests support for Tensorflow.js -This package enables users to run arbitary Tensorflow Decision Forests models +This package enables users to run arbitrary Tensorflow Decision Forests models on the web that are converted using tfjs-converter. Users can load a TFDF model from a URL, use TFJS tensors to set the model's input data, run inference, and get the output back in TFJS tensors. diff --git a/tfjs-vis/demos/mnist/index.html b/tfjs-vis/demos/mnist/index.html index 6ecf19ea990..b51a164746b 100644 --- a/tfjs-vis/demos/mnist/index.html +++ b/tfjs-vis/demos/mnist/index.html @@ -94,7 +94,7 @@

The Visor

  • ` (backtick): Shows or hides the visor
  • - ~ (tilde, shift+backtick): Toggles betweeen the two sizes the visor supports
    • + ~ (tilde, shift+backtick): Toggles between the two sizes the visor supports The API allows you to disable (unbind) these keyboard shortcuts.

    @@ -317,7 +317,7 @@

    Customizing training charts.

    Evaluating Our Model

    - Now that our model is trained we should evalute its performance. For a classification task like this one we can + Now that our model is trained we should evaluate its performance. For a classification task like this one we can use the `perClassAccuracy` and `confusionMatrix` functions. These are demonstrated below.

    diff --git a/tfjs-vis/src/components/surface.tsx b/tfjs-vis/src/components/surface.tsx index 6eb67bd5f62..56ed114692c 100644 --- a/tfjs-vis/src/components/surface.tsx +++ b/tfjs-vis/src/components/surface.tsx @@ -27,7 +27,7 @@ interface SurfaceProps extends SurfaceInfoStrict { } /** - * A surface is container for visualizations and other rendered thigns. + * A surface is container for visualizations and other rendered things. * It consists of a containing DOM Element, a label and an empty drawArea. */ export class SurfaceComponent extends Component { diff --git a/tfjs-vis/src/components/visor.tsx b/tfjs-vis/src/components/visor.tsx index d9df73665f7..4a7ff16e85f 100644 --- a/tfjs-vis/src/components/visor.tsx +++ b/tfjs-vis/src/components/visor.tsx @@ -28,7 +28,7 @@ interface VisorProps { // objects that allow configuration of the surface. The actual surface // instance is managed by the visor. surfaceList: SurfaceInfoStrict[]; - // Whether to inialize the visor to the open or closed state. Optional. + // Whether to initialize the visor to the open or closed state. Optional. startOpen?: boolean; // A ref handler ref?: (r: VisorComponent) => void; diff --git a/tfjs-vis/src/types.ts b/tfjs-vis/src/types.ts index c06a47d4b34..7af39c38f41 100644 --- a/tfjs-vis/src/types.ts +++ b/tfjs-vis/src/types.ts @@ -141,11 +141,11 @@ export interface VisOptions { */ export interface XYPlotOptions extends VisOptions { /** - * domain of the x axis. Overriden by zoomToFit + * domain of the x axis. Overridden by zoomToFit */ xAxisDomain?: [number, number]; /** - * domain of the y axis. Overriden by zoomToFit + * domain of the y axis. Overridden by zoomToFit */ yAxisDomain?: [number, number]; /** From ff967a7d0373cb1f47d25e4459c36b22d301880a Mon Sep 17 00:00:00 2001 From: shmishra99 Date: Sat, 24 Jun 2023 17:01:16 +0530 Subject: [PATCH 4/4] Fixed typos in documentation string. --- .../src/operations/executors/hash_table_executor_test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tfjs-converter/src/operations/executors/hash_table_executor_test.ts b/tfjs-converter/src/operations/executors/hash_table_executor_test.ts index 64cc3d12ed6..1d4b1972f78 100644 --- a/tfjs-converter/src/operations/executors/hash_table_executor_test.ts +++ b/tfjs-converter/src/operations/executors/hash_table_executor_test.ts @@ -262,7 +262,7 @@ describe('hash_table', () => { const before = memory().numTensors; try { await executeOp(node, {input3, input5}, context, resourceManager); - fail('Shoudl fail, succeed unexpectedly.'); + fail('Should fail, succeed unexpectedly.'); } catch (err) { expect(err).toMatch(/Expect key dtype/); }