From 7d471be29c3efde06efd575b107463588e230f9d Mon Sep 17 00:00:00 2001
From: Ata Tuzuner <atuzuner@tenstorrent.com>
Date: Fri, 10 Jan 2025 17:00:36 +0000
Subject: [PATCH] Removed default values from all internal APIs in compute test
 kernels. Call chains updated accordingly.

---
 tests/tt_metal/tt_metal/test_kernels/compute/reduce_h.cpp     | 4 ++--
 tests/tt_metal/tt_metal/test_kernels/compute/reduce_hw.cpp    | 4 ++--
 tests/tt_metal/tt_metal/test_kernels/compute/reduce_w.cpp     | 4 ++--
 .../tt_metal/test_kernels/compute/unpack_tilizeA_B.cpp        | 2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/tests/tt_metal/tt_metal/test_kernels/compute/reduce_h.cpp b/tests/tt_metal/tt_metal/test_kernels/compute/reduce_h.cpp
index 042834e55f1..9ba9e520a7e 100644
--- a/tests/tt_metal/tt_metal/test_kernels/compute/reduce_h.cpp
+++ b/tests/tt_metal/tt_metal/test_kernels/compute/reduce_h.cpp
@@ -25,7 +25,7 @@
  * argument is tested. Reference llk_pack_reduce_config_v2 for more details.
  */
 template <bool at_start, PoolType reduce_type = REDUCE_OP, ReduceDim reduce_dim = REDUCE_DIM>
-ALWI void dummy_init(uint32_t icb = 0, uint32_t icb_scaler = 1, uint32_t ocb = 16) {
+ALWI void dummy_init(uint32_t icb, uint32_t icb_scaler, uint32_t ocb) {
 #ifdef SHORT_INIT
     UNPACK((llk_unpack_AB_hw_configure_disaggregated<DST_ACCUM_MODE>(icb, icb_scaler)));
 
@@ -44,7 +44,7 @@ void MAIN {
     constexpr uint32_t Wt = get_compile_time_arg_val(1);
     constexpr uint32_t NC = get_compile_time_arg_val(2);
     constexpr bool at_start = get_compile_time_arg_val(3);
-    dummy_init<at_start>(tt::CBIndex::c_0, tt::CBIndex::c_2);
+    dummy_init<at_start>(tt::CBIndex::c_0, tt::CBIndex::c_2, tt::CBIndex::c_16);
 #ifndef SHORT_INIT
     reduce_init<at_start>(tt::CBIndex::c_0, tt::CBIndex::c_2);
 #else
diff --git a/tests/tt_metal/tt_metal/test_kernels/compute/reduce_hw.cpp b/tests/tt_metal/tt_metal/test_kernels/compute/reduce_hw.cpp
index 6a55285a540..02366a91575 100644
--- a/tests/tt_metal/tt_metal/test_kernels/compute/reduce_hw.cpp
+++ b/tests/tt_metal/tt_metal/test_kernels/compute/reduce_hw.cpp
@@ -25,7 +25,7 @@
  * argument is tested. Reference llk_pack_reduce_config_v2 for more details.
  */
 template <bool at_start, PoolType reduce_type = REDUCE_OP, ReduceDim reduce_dim = REDUCE_DIM>
-ALWI void dummy_init(uint32_t icb = 0, uint32_t icb_scaler = 1, uint32_t ocb = 16) {
+ALWI void dummy_init(uint32_t icb, uint32_t icb_scaler, uint32_t ocb) {
 #ifdef SHORT_INIT
     UNPACK((llk_unpack_AB_hw_configure_disaggregated<DST_ACCUM_MODE>(icb, icb_scaler)));
 
@@ -44,7 +44,7 @@ void MAIN {
     constexpr uint32_t Wt = get_compile_time_arg_val(1);
     constexpr uint32_t NC = get_compile_time_arg_val(2);
     constexpr bool at_start = get_compile_time_arg_val(3);
-    dummy_init<at_start>(tt::CBIndex::c_0, tt::CBIndex::c_2);
+    dummy_init<at_start>(tt::CBIndex::c_0, tt::CBIndex::c_2, tt::CBIndex::c_16);
 #ifndef SHORT_INIT
     reduce_init<at_start>(tt::CBIndex::c_0, tt::CBIndex::c_2);
 #else
diff --git a/tests/tt_metal/tt_metal/test_kernels/compute/reduce_w.cpp b/tests/tt_metal/tt_metal/test_kernels/compute/reduce_w.cpp
index e041a7a99a2..dcdf7ac63d8 100644
--- a/tests/tt_metal/tt_metal/test_kernels/compute/reduce_w.cpp
+++ b/tests/tt_metal/tt_metal/test_kernels/compute/reduce_w.cpp
@@ -25,7 +25,7 @@
  * argument is tested. Reference llk_pack_reduce_config_v2 for more details.
  */
 template <bool at_start, PoolType reduce_type = REDUCE_OP, ReduceDim reduce_dim = REDUCE_DIM>
-ALWI void dummy_init(uint32_t icb = 0, uint32_t icb_scaler = 1, uint32_t ocb = 16) {
+ALWI void dummy_init(uint32_t icb, uint32_t icb_scaler, uint32_t ocb) {
 #ifdef SHORT_INIT
     UNPACK((llk_unpack_AB_hw_configure_disaggregated<DST_ACCUM_MODE>(icb, icb_scaler)));
 
@@ -44,7 +44,7 @@ void MAIN {
     constexpr uint32_t Wt = get_compile_time_arg_val(1);
     constexpr uint32_t NC = get_compile_time_arg_val(2);
     constexpr bool at_start = get_compile_time_arg_val(3);
-    dummy_init<at_start>(tt::CBIndex::c_0, tt::CBIndex::c_2);
+    dummy_init<at_start>(tt::CBIndex::c_0, tt::CBIndex::c_2, tt::CBIndex::c_16);
 #ifndef SHORT_INIT
     reduce_init<at_start>(tt::CBIndex::c_0, tt::CBIndex::c_2);
 #else
diff --git a/tests/tt_metal/tt_metal/test_kernels/compute/unpack_tilizeA_B.cpp b/tests/tt_metal/tt_metal/test_kernels/compute/unpack_tilizeA_B.cpp
index 3e48f987931..7511dcdd74d 100644
--- a/tests/tt_metal/tt_metal/test_kernels/compute/unpack_tilizeA_B.cpp
+++ b/tests/tt_metal/tt_metal/test_kernels/compute/unpack_tilizeA_B.cpp
@@ -10,7 +10,7 @@
 
 // #include "debug/dprint.h"
 inline void tilizeA_B_binary_init(
-    uint32_t icb0, uint32_t icb1, uint32_t block, uint32_t ocb = 16, uint32_t num_faces = 4, uint32_t face_r_dim = 16) {
+    uint32_t icb0, uint32_t icb1, uint32_t block, uint32_t ocb, uint32_t num_faces = 4, uint32_t face_r_dim = 16) {
     UNPACK((llk_unpack_tilizeA_B_hw_configure_disaggregated<DST_ACCUM_MODE>(icb0, icb1)));
     UNPACK((llk_unpack_tilizeA_B_init<true, true>(icb0, icb1, block, num_faces, face_r_dim, face_r_dim)));