Handle different value types for constant op explicitly for TTNN backend #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmanzoorTT
requested review from
sdjordjevicTT,
svuckovicTT,
mtopalovicTT,
rpavlovicTT and
jserbedzijaTT
as code owners
|
Can you please attach the relevant issue? Or if we don't have one, can you please create one? |
nsmithtt
reviewed
Nov 6, 2024
Created an issue and linked it. |
mmanzoorTT
force-pushed
the
mmanzoor/ttnn-constant
branch
from
2759638 to
3f22348
Compare
sdjordjevicTT
approved these changes
Nov 8, 2024
mmanzoorTT
force-pushed
the
mmanzoor/ttnn-constant
branch
from
3f22348 to
b2f947e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1180