Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autogenerate TTNN Tests for Explorer CI to consume #1333

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Autogenerate TTNN Tests for Explorer CI to consume #1333

wants to merge 27 commits into from

Conversation

vprajapati-tt
Copy link
Contributor

@vprajapati-tt vprajapati-tt commented Nov 19, 2024 •
edited
Loading

@vprajapati-tt vprajapati-tt changed the title Autogenerate TTNN Tests for CI to consume Autogenerate TTNN Tests for Explorer CI to consume Nov 19, 2024
@vprajapati-tt vprajapati-tt mentioned this pull request Nov 19, 2024
Open
odjuricicTT
odjuricicTT reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@odjuricicTT odjuricicTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have this functionality so we can run explorer no all these files. Not sure if we want it in CI tho. Left a comment.

.github/workflows/build-and-test.yml Outdated Show resolved Hide resolved
.github/workflows/build-and-test.yml Outdated Show resolved Hide resolved
@vprajapati-tt vprajapati-tt linked an issue Dec 9, 2024 that may be closed by this pull request
Explorer Tests are manually defined in tools/test folder #1297
Open
odjuricicTT
odjuricicTT requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@odjuricicTT odjuricicTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we get the tests to pass, let's also check the duration of the job before merging this.

@vprajapati-tt
Copy link
Contributor Author

Awesome. we're finally seeing some additional coverage and catching failpoints in explorer :) I'll address these fixes + add TTIR modules from the tests directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odjuricicTT odjuricicTT odjuricicTT requested changes

@vmilosevic vmilosevic vmilosevic approved these changes

@svuckovicTT svuckovicTT svuckovicTT approved these changes

@tapspatel tapspatel tapspatel approved these changes

@nobradovictt nobradovictt Awaiting requested review from nobradovictt

@nsmithtt nsmithtt Awaiting requested review from nsmithtt

@mtopalovicTT mtopalovicTT Awaiting requested review from mtopalovicTT

@sdjordjevicTT sdjordjevicTT Awaiting requested review from sdjordjevicTT sdjordjevicTT is a code owner

@tt-mpantic tt-mpantic Awaiting requested review from tt-mpantic tt-mpantic is a code owner

@vcanicTT vcanicTT Awaiting requested review from vcanicTT vcanicTT is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explorer Tests are manually defined in tools/test folder
6 participants
@vprajapati-tt @nsmithtt @tapspatel @svuckovicTT @vmilosevic @odjuricicTT